doc: Add SQL examples for SEMI + ANTI Joins #16316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the SQL documentation by introducing examples and explanations for semi and anti join variants.
- Expanded the JOIN clause overview to include
LEFT SEMI,RIGHT SEMI,LEFT ANTI, andRIGHT ANTIjoins. - Added descriptive text and SQL examples for each new join type.
- Performed minor formatting cleanup on existing SQL snippets.
Comments suppressed due to low confidence (1)
docs/source/user-guide/sql/select.md:202
- [nitpick] For parallel structure with the LEFT SEMI JOIN description, consider rephrasing to 'projects only the columns from the right table.'
only projects the columns from the right table.
docs/source/user-guide/sql/select.md
Outdated
| right side of the join. | ||
|
|
||
| ```sql | ||
| select * from x cross join x y; | ||
| SELECT * from x CROSS JOIN x y; |
There was a problem hiding this comment.
[nitpick] Use consistent uppercase SQL keywords; change 'from' to 'FROM' to match other examples.
Suggested change
| SELECT * from x CROSS JOIN x y; | |
| SELECT * FROM x CROSS JOIN x y; |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
@jonathanc-n I think it makes sense haha
There was a problem hiding this comment.
oops missed that one
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alamb
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
Thank you @jonathanc-n -- this looks like a nice change to me
niebayes
approved these changes
Jun 12, 2025
zhuqi-lucas
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
We are currently missing documentation on
Left Mark Join,Right Mark Join,Left Semi JoinandRight Semi Join. We should add an explanation for how they work + sql examples.What changes are included in this PR?
Added sql examples + explanation for
Left Mark Join,Right Mark Join,Left Semi JoinandRight Semi Join. Also did some drive by clean up to make the sql examples a little nicer 😄Are these changes tested?
No, just doc changes
Are there any user-facing changes?
Yes, documentation for the different join clauses